Refactoring conditional code implementation based on refactoring simplified conditional logic
1. The existing implementation is as follows
semantic = $semantic;
}
/**
* 对比两个「PHP 规范化」的版本数字字符串，添加例外：-h.
* @param self $version
* @return int 在第一个参数小于，等于或大于第二个参数时，该比较函数必须相应地返回一个小于，等于或大于 0 的整数
*/
public function compare(self $version): int
{
if (Str::contains($this->semantic, self::SPECIAL_IDENTIFIER) && !Str::contains($version->semantic, self::SPECIAL_IDENTIFIER) && Str::before($this->semantic, self::HYPHEN) == Str::before($version->semantic, self::HYPHEN)) {
return 1;
} elseif (!Str::contains($this->semantic, self::SPECIAL_IDENTIFIER) && Str::contains($version->semantic, self::SPECIAL_IDENTIFIER) && Str::before($this->semantic, self::HYPHEN) == Str::before($version->semantic, self::HYPHEN)) {
return -1;
} else {
return version_compare($this->semantic, $version->semantic);
}
}
2. Reference 10.1 Decompose conditional expression (decompose conditional), adjust to the following
semantic = $semantic;
}
/**
* 对比两个「PHP 规范化」的版本数字字符串，添加例外：-h.
* @param self $version
* @return int 在第一个参数小于，等于或大于第二个参数时，该比较函数必须相应地返回一个小于，等于或大于 0 的整数
*/
public function compare(self $version): int
{
if (self::isSpecial($this->semantic) && !self::isSpecial($version->semantic) && self::isMainEqual($this->semantic, $version->semantic)) {
return 1;
} elseif (!self::isSpecial($this->semantic) && self::isSpecial($version->semantic) && self::isMainEqual($this->semantic, $version->semantic)) {
return -1;
} else {
return version_compare($this->semantic, $version->semantic);
}
}
/**
* 返回版本是否是特殊版本
* @param string $semantic
* @return bool
*/
private static function isSpecial(string $semantic): bool
{
return Str::contains($semantic, self::SPECIAL_IDENTIFIER);
}
/**
* 返回两个版本的主版本号是否相等
* @param string $semantic1
* @param string $semantic2
* @return bool
*/
private static function isMainEqual(string $semantic1, string $semantic2): bool
{
return self::getMain($semantic1) == self::getMain($semantic2);
}
/**
* 获取版本的主版本号
* @param string $semantic
* @return string
*/
private static function getMain(string $semantic): string
{
return Str::before($semantic, self::HYPHEN);
}
}
3. 10.2 Consolidate conditional expression (Consolidate conditional expression). Extracting the inspection conditions into a separate function is very useful for clarifying the meaning of the code, because it replaces the statement describing “what to do” with “why do this”.
/**
* 对比两个「PHP 规范化」的版本数字字符串，添加例外：-h.
* @param self $version
* @return int 在第一个参数小于，等于或大于第二个参数时，该比较函数必须相应地返回一个小于，等于或大于 0 的整数
*/
public function compare(self $version): int
{
if (self::isSpecialGt($this->semantic, $version->semantic)) {
return 1;
} elseif (self::isSpecialLt($this->semantic, $version->semantic)) {
return -1;
} else {
return version_compare($this->semantic, $version->semantic);
}
}
/**
* 当两个版本中仅存在一个特殊版本时，第一个版本大于第二个版本
* @param string $semantic1
* @param string $semantic2
* @return bool
*/
private static function isSpecialGt(string $semantic1, string $semantic2): bool
{
return self::isSpecial($semantic1) && !self::isSpecial($semantic2) && self::isMainEqual($semantic1, $semantic2);
}
/**
* 当两个版本中仅存在一个特殊版本时，第一个版本小于第二个版本
* @param string $semantic1
* @param string $semantic2
* @return bool
*/
private static function isSpecialLt(string $semantic1, string $semantic2): bool
{
return !self::isSpecial($semantic1) && self::isSpecial($semantic2) && self::isMainEqual($semantic1, $semantic2);
}
}
4. 10.3 Replace nested conditional expressions (Replace Nested Conditional with Guard Clauses). If a condition is extremely rare, the condition should be checked separately and immediately returned from the function when the condition is true. Such individual checks are often referred to as “guard clauses”.
semantic = $semantic;
}
/**
* 对比两个「PHP 规范化」的版本数字字符串，添加例外：-h.
* @param self $version
* @return int 在第一个参数小于，等于或大于第二个参数时，该比较函数必须相应地返回一个小于，等于或大于 0 的整数
*/
public function compare(self $version): int
{
if (self::isSpecialGt($this->semantic, $version->semantic)) {
return 1;
}
if (self::isSpecialLt($this->semantic, $version->semantic)) {
return -1;
}
return version_compare($this->semantic, $version->semantic);
}
/**
* 返回版本是否是特殊版本
* @param string $semantic
* @return bool
*/
private static function isSpecial(string $semantic): bool
{
return Str::contains($semantic, self::SPECIAL_IDENTIFIER);
}
/**
* 返回两个版本的主版本号是否相等
* @param string $semantic1
* @param string $semantic2
* @return bool
*/
private static function isMainEqual(string $semantic1, string $semantic2): bool
{
return self::getMain($semantic1) == self::getMain($semantic2);
}
/**
* 获取版本的主版本号
* @param string $semantic
* @return string
*/
private static function getMain(string $semantic): string
{
return Str::before($semantic, self::HYPHEN);
}
/**
* 当两个版本中仅存在一个特殊版本时，第一个版本大于第二个版本
* @param string $semantic1
* @param string $semantic2
* @return bool
*/
private static function isSpecialGt(string $semantic1, string $semantic2): bool
{
return self::isSpecial($semantic1) && !self::isSpecial($semantic2) && self::isMainEqual($semantic1, $semantic2);
}
/**
* 当两个版本中仅存在一个特殊版本时，第一个版本小于第二个版本
* @param string $semantic1
* @param string $semantic2
* @return bool
*/
private static function isSpecialLt(string $semantic1, string $semantic2): bool
{
return !self::isSpecial($semantic1) && self::isSpecial($semantic2) && self::isMainEqual($semantic1, $semantic2);
}
}
